Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java]Compatible with lower versions of guava #1593

Closed
2 tasks done
MrChang0 opened this issue Apr 29, 2024 · 0 comments
Closed
2 tasks done

[Java]Compatible with lower versions of guava #1593

MrChang0 opened this issue Apr 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MrChang0
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar issues.

Version

master

Component(s)

Java

Minimal reproduce step

dependency fury and guava version 18

What did you expect to see?

run without error

What did you see instead?

Caused by: java.lang.NoSuchMethodError: com.google.common.collect.ImmutableBiMap$Builder: method 'void (int)' not found

Anything Else?

with guava 18, ImmutableMap.Builder only Builder() contructor.
builderCtrCache should support lookup.findConstructor(builderClass, MethodType.methodType(void.class)); when throw excption.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@MrChang0 MrChang0 added the bug Something isn't working label Apr 29, 2024
@MrChang0 MrChang0 changed the title Compatible with lower versions of guava [Java]Compatible with lower versions of guava Apr 29, 2024
@MrChang0 MrChang0 mentioned this issue Apr 29, 2024
Merged
2 tasks
chaokunyang pushed a commit that referenced this issue Apr 29, 2024
@MrChang0
fix(java): compatible low version guava(#1593) (#1594)
b6f9024 

## What does this PR do?

compatible low version guava

## Related issues

- #1593


## Does this PR introduce any user-facing change?

<!--
If any user-facing interface changes, please [open an
issue](https://github.com/apache/incubator-fury/issues/new/choose)
describing the need to do so and update the document if necessary.
-->

- [ ] Does this PR introduce any public API change?
- [ ] Does this PR introduce any binary protocol compatibility change?


## Benchmark

<!--
When the PR has an impact on performance (if you don't know whether the
PR will have an impact on performance, you can submit the PR first, and
if it will have impact on performance, the code reviewer will explain
it), be sure to attach a benchmark data here.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaokunyang @MrChang0