Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(java): make enum serializer as an upper level class #1598

Merged
merged 1 commit into from
May 5, 2024

Conversation

chaokunyang
Copy link
Collaborator

What does this PR do?

Enum is a core concept in fury serialization, and we will have more specific optimization on this type.

This make enum serializer as an upper level class, so we can make all enum releated code more cohesive

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

Copy link
Contributor

@LiangliangSui LiangliangSui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit aa070b9 into main May 5, 2024
32 checks passed
@chaokunyang chaokunyang deleted the make_enum_serializer_as_an_upperlevel_class branch May 5, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants