feat(java): support deserialization ignoreEnumDeserializeError #1623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weijiang157152688
force-pushed
the
ignoreEnumDeserializeError
branch
from
ab544bd
to
8a9b153
Compare
weijiang157152688
changed the title
weijiang157152688
changed the title
weijiang157152688
changed the title
weijiang157152688
force-pushed
the
ignoreEnumDeserializeError
branch
from
8a9b153
to
a8dba5b
Compare
weijiang157152688
changed the title
chaokunyang
reviewed
May 10, 2024
| @@ -54,6 +54,7 @@ public class Config implements Serializable { | |||
| private final boolean deserializeUnexistedClass; | |||
| private final boolean scalaOptimizationEnabled; | |||
| private transient int configHash; | |||
| private final boolean enumDeserializeErrorIgnored; | |||
There was a problem hiding this comment.
How about naming it as deserializeUnexistentEnumValueAsNull
chaokunyang
reviewed
May 11, 2024
| @@ -49,7 +49,7 @@ public void write(MemoryBuffer buffer, Enum value) { | |||
| @Override | |||
| public Enum read(MemoryBuffer buffer) { | |||
| int value = buffer.readVarUint32Small7(); | |||
| if (fury.getConfig().isEnumDeserializeErrorIgnored() && value >= enumConstants.length) { | |||
| if (fury.getConfig().isDeserializeUnexistentEnumValueAsNull() && value >= enumConstants.length) { | |||
There was a problem hiding this comment.
Suggested change
| if (fury.getConfig().isDeserializeUnexistentEnumValueAsNull() && value >= enumConstants.length) { | |
| if (fury.getConfig().deserializeUnexistentEnumValueAsNull() && value >= enumConstants.length) { |
weijiang157152688
force-pushed
the
ignoreEnumDeserializeError
branch
from
134ef3c
to
d64b43d
Compare
chaokunyang
reviewed
May 11, 2024
ci/format.sh
Outdated
| @@ -25,6 +25,8 @@ install_nodejs() { | |||
| node -v | |||
| npm -v | |||
| } | |||
| export python=/home/t5/weijiang/work/score/fury/1/Python-3.8.18/python3.8/bin/python3.8 | |||
chaokunyang
reviewed
May 11, 2024
ci/format.sh
Outdated
| @@ -180,7 +182,7 @@ format_all_scripts() { | |||
| } | |||
|
|
|||
| format_java() { | |||
| if command -v mvn >/dev/null ; then | |||
chaokunyang
reviewed
May 11, 2024
| @@ -100,6 +102,10 @@ public boolean isStringRefIgnored() { | |||
| return stringRefIgnored; | |||
| } | |||
|
|
|||
chaokunyang
reviewed
May 11, 2024
| @@ -100,6 +102,10 @@ public boolean isStringRefIgnored() { | |||
| return stringRefIgnored; | |||
| } | |||
|
|
|||
| public boolean isDeserializeUnexistentEnumValueAsNull() { | |||
There was a problem hiding this comment.
Rename to deserializeUnexistentEnumValueAsNull
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issues
Does this PR introduce any user-facing change?
Benchmark