This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
fix GEARPUMP-122, refactor kafka connector API #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| override def open(context: TaskContext, startTime: TimeStamp): Unit = { | ||
| import context.{parallelism, taskId} | ||
|
|
||
| LOG.info("KafkaSource opened at start time {}", startTime) |
There was a problem hiding this comment.
I think adding the topic list that are consumed to the log is better.
There was a problem hiding this comment.
We already log assigned partitions below. Will that be sufficient ?
There was a problem hiding this comment.
all right, I missed that part.
|
Documentation update? |
|
may I update doc as follow-up ? |
| props.put(KafkaConfig.CHECKPOINT_STORE_NAME_PREFIX_CONFIG, appName) | ||
| val source = new KafkaSource(sourceTopic, props) | ||
| val checkpointStoreFactory = new KafkaStoreFactory(props) | ||
| source.checkpoint(checkpointStoreFactory) |
There was a problem hiding this comment.
What if user doesn't call checkpoint?
There was a problem hiding this comment.
then kafka offsets will not be checkpointed
Current coverage is 63.75%
@@ master #25 diff @@
==========================================
Files 180 177 -3
Lines 5956 5898 -58
Methods 5678 5626 -52
Messages 0 0
Branches 278 272 -6
==========================================
- Hits 3818 3760 -58
Misses 2138 2138
Partials 0 0
|
| /** | ||
| * for tests only | ||
| */ | ||
| void addPartitionAndStore(TopicAndPartition tp, CheckpointStore store) { |
|
please do not merge. I need to verify whether integration test passes |
manuzhang
force-pushed
the
kafka
branch
6 times, most recently
from
aac082b
to
ae6671a
Compare
|
I've verified related integration tests pass |
manuzhang
force-pushed
the
kafka
branch
3 times, most recently
from
a48d95a
to
9c5052a
Compare
|
UT failed |
|
+1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly refactor the Kafka connector API with the following changes:
OffsetStorageandKafkaStorage, and usesCheckpointStoreandKafkaStorefor both offset and state checkpoint stores.checkpoint(CheckpointStoreFactory)method toTimeReplayableSourcewhich makes offset store configurable by user. Ifcheckpointis not called, then no offset checkpoint will be performed and applications run in at-most-once mode.KafkaSource,KafkaSinkandKafkaStoreto Java and keeps their implementations in Scala, which prevents Scala package private methods being exposed in Java programs.KafkaSource,KafkaSinkandKafkaStoreare all configurable through Java properties which is the standard Kafka way.