Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CH] salt 1% of TPCH-1 data to NULL instead of 10% #3879

Closed
binmahone opened this issue Nov 29, 2023 · 0 comments · Fixed by #3880
Closed

[CH] salt 1% of TPCH-1 data to NULL instead of 10% #3879

binmahone opened this issue Nov 29, 2023 · 0 comments · Fixed by #3880
Labels
enhancement New feature or request

Comments

@binmahone
Copy link
Contributor

binmahone commented Nov 29, 2023 •
edited
Loading

Description

Currently , in GlutenClickHouseTPCHParquetSuite#createTPCHNullableTables we'll RANDOMLY salt 10% data to NULL to test null values. For a single row, each column of the row will have a 10% chance to be NULL, this adds up to a higher chance of a sql returning 0 records. E.g. TPCH Q2:

  • 10% salt returning 0 rows (not everytime, but with a higher chance)
    image

  • 1% salt:
    image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[GLUTEN-3879][CH] salt 1% of TPCH-1 data to NULL instead of 10% binmahone/gluten2
1 participant
@binmahone