This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
remove inputs from streamlet since the core streamlet class does not use it #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aahmed-se
reviewed
Aug 18, 2017
| @@ -79,5 +79,5 @@ def _build_this(self, builder): | |||
| if not callable(self._filter_function): | |||
| raise RuntimeError("filter function must be callable") | |||
| builder.add_bolt(self._stage_name, FilterBolt, par=self._parallelism, | |||
| inputs=self._inputs, | |||
| inputs=self._calculate_inputs(), | |||
There was a problem hiding this comment.
You are deleting this function
There was a problem hiding this comment.
I'm deleting the interface function from streamlet, but letting all other derivates implement calculating inputs in their own way. Thus the _calculate_inputs method here is the local one defined above in the same file
aahmed-se
approved these changes
Aug 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.