Use cereal lib configured in WORKSPACE and remove tar.gz #2986
Conversation
|
@kramasamy @srkukarni I saw you guys added the tar.gz file and changed the version from 1.2.2 to 1.2.1 in git log. And from git log there seems to be a patch file before but it is not in this folder any more. Could you please take a look at this PR? And do I need to change 1.2.2 to 1.2.1? Thanks in advance. |
| @@ -116,9 +116,7 @@ genrule( | |||
|
|
|||
| cc_library( | |||
| name = "cereal-cxx", | |||
| srcs = [ | |||
| "empty.cc", | |||
There was a problem hiding this comment.
IIRC, the empty file is needed for compiling correctly
There was a problem hiding this comment.
"bazel build --config=darwin heron/..." seems to be working ok for me locally. Doing another clean rebuild now.
There was a problem hiding this comment.
Builds ok.
INFO: Elapsed time: 1086.264s, Critical Path: 195.24s
INFO: 2515 processes: 2202 local, 313 worker.
INFO: Build completed successfully, 4264 total actions
|
@nlu90 - you don't need BUILD, *.tar.gz and empty.cc at all. All you need cereal.BUILD - nothing else. |
|
Those files can be safely removed. |
|
@nlu90 - the files BUILD, empty.cc can be removed. |
No description provided.