This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
memory leak in tmaster fixed #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
1 similar comment
|
👍 |
nwangtw
approved these changes
Apr 1, 2019
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory leak in TMaster was reported by one of the Twitter internal clients.
After running TMaster under Valgrind memory leaks detector, the leak was localized.
This PR aims to fix it.
GetStmgrsRegSummary()now returns a smart pointer (unique_ptr<>). So, as soon as a caller no need the returned result anymore the memory is freed automatically.Tested this PR locally under Valgrind and don't see the leak anymore.