This repository has been archived by the owner on Mar 3, 2023. It is now read-only.
Docker build should not remove heron-core.tar.gz #3291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
KK. Make sense. It was removed to reduce image size, but "docker run" was used for testing instead of "heron submit". This change makes sense. We will find another way to reduce size later. Thanks. |
nwangtw
approved these changes
Jun 17, 2019
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Apr 9, 2020
nicknezis
pushed a commit
that referenced
this pull request
Sep 14, 2020
sreev
pushed a commit
to sreev/incubator-heron
that referenced
this pull request
Nov 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file
/usr/local/heron/dist/heron-core.tar.gzis used duringheron submitcommand. This file should not be removed during docker build, otherwiseheron submitwill not succeed.