Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Helm chart cleanup #3758

Merged
merged 4 commits into from
Jan 17, 2022
Merged

Helm chart cleanup #3758

merged 4 commits into from
Jan 17, 2022

Conversation

nicknezis
Copy link
Contributor

  1. Updated Helm to 3.7.2.
  2. Added LICENSE, NOTICE and DISCLAIMER files to Helm chart
  3. Updated the Helm chart.yaml apiVersion to v2 (Helm 3.x)

Helm v2 is necessary to make the Helm chart discoverable in the apache.jfrog.org Helm repo.

I tried to find a way to instruct Helm to leave the commented LICENSE header in the Chart.yaml, but it seems the Chart.yaml is always processed to a final form with no comments.

@nicknezis nicknezis self-assigned this Jan 17, 2022
@nicknezis nicknezis added this to In progress in 0.20.5 Remaining tasks via automation Jan 17, 2022
0.20.5 Remaining tasks automation moved this from In progress to Reviewer approved Jan 17, 2022
@nicknezis nicknezis merged commit 482f14f into master Jan 17, 2022
0.20.5 Remaining tasks automation moved this from Reviewer approved to Done Jan 17, 2022
@nicknezis nicknezis deleted the nicknezis/helm-cleanup branch January 17, 2022 16:50
@surahman
Copy link
Member

For posterity:

I tried to find a way to instruct Helm to leave the commented LICENSE header in the Chart.yaml, but it seems the Chart.yaml is always processed to a final form with no comments.

As per the conversation Nick initiated on dev@h.a.o on this issue, it is acceptable for a file that is generated or processed to not contain the ASF header. I also have been unable to find a way to work around the pre-processing performed server/client-side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants