Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql backend openWithoutDB ssl-mode not work #842

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Fix mysql backend openWithoutDB ssl-mode not work #842

merged 3 commits into from
Feb 20, 2020

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Jan 22, 2020

Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #842 into master will decrease coverage by 15.36%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master     #842       +/-   ##
=============================================
- Coverage     71.82%   56.45%   -15.37%     
+ Complexity     4386     3403      -983     
=============================================
  Files           286      286               
  Lines         21084    21084               
  Branches       2967     2969        +2     
=============================================
- Hits          15144    11904     -3240     
- Misses         4450     7850     +3400     
+ Partials       1490     1330      -160     
Impacted Files Coverage Δ Complexity Δ
...va/com/baidu/hugegraph/io/HugeGraphIoRegistry.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...aidu/hugegraph/exception/HugeGremlinException.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ugegraph/backend/store/memory/InMemoryMetrics.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...graph/backend/store/scylladb/ScyllaDBFeatures.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
.../backend/store/scylladb/ScyllaDBStoreProvider.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-7.00%)
...ackend/store/cassandra/CassandraStoreProvider.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...h/backend/store/scylladb/ScyllaDBTablesWithMV.java 0.00% <0.00%> (-96.04%) 0.00% <0.00%> (-10.00%)
...ava/com/baidu/hugegraph/analyzer/WordAnalyzer.java 0.00% <0.00%> (-92.31%) 0.00% <0.00%> (-4.00%)
...h/backend/store/cassandra/CassandraSerializer.java 0.00% <0.00%> (-90.48%) 0.00% <0.00%> (-27.00%)
...m/baidu/hugegraph/io/GraphSONSchemaSerializer.java 0.00% <0.00%> (-88.06%) 1.00% <0.00%> (-9.00%)
... and 116 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5692844...1e46ed0. Read the comment docs.

Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create issue for the fix.
And is this issue https://github.com/hugegraph/hugegraph/issues/838 related to openWithoutDB()

.setParameter("socketTimeout",
String.valueOf(timeout))
.toString();
String url = this.buildUri(true, timeout);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the origin logic is autoReconnect=false and no database parameter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoReconnect really do not need, but need useSSL param

@I-DO-NOT-KNOW
Copy link

Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31

你好,请问下现在是怎么解决0.10.4版本openWithoutDB ssl-mode不起作用这个问题。现在初始化mysql一直报SSL这个问题。

@javeme
Copy link
Contributor

javeme commented Feb 12, 2020

@I-DO-NOT-KNOW 可以cherry-pick这个commit

@I-DO-NOT-KNOW
Copy link

@I-DO-NOT-KNOW 可以cherry-pick这个commit

好的,谢谢

Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31
@Linary
Copy link
Contributor Author

Linary commented Feb 18, 2020

MySQL backend, execute init-store.sh

28e823c767648ec3de7ff6522

Change-Id: I542c42cb6cb5ead6f3046661f66ea0583ff1c671
Change-Id: I457247da404b2dea44f272e9eec60345baa048d6
@javeme javeme merged commit 145bf0c into master Feb 20, 2020
@javeme javeme deleted the ssl-mode branch February 20, 2020 18:01
javeme pushed a commit that referenced this pull request Jun 18, 2020
* Fix mysql backend openWithoutDB ssl-mode not work

Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31
Linary added a commit that referenced this pull request Jun 19, 2020
* Fix mysql backend openWithoutDB ssl-mode not work (#842)
* fix bug of missing offset with index query (#866)
* allow system async task in gremlin context (#892)
* sm allow cassandra backend creating thread as needed while execute cql (#896)
* fix: Invalid limit 10000000, must be <= capacity (#950)
* Fix gremlin-console can't work (#1027)

Change-Id: Ice222d809e4161f1d4d1f04822bef1c5af380a10

Co-authored-by: Linary <liningrui@vip.qq.com>
Co-authored-by: zhoney <zhangyi51@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants