-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mysql backend openWithoutDB ssl-mode not work #842
Conversation
Codecov Report
@@ Coverage Diff @@
## master #842 +/- ##
=============================================
- Coverage 71.82% 56.45% -15.37%
+ Complexity 4386 3403 -983
=============================================
Files 286 286
Lines 21084 21084
Branches 2967 2969 +2
=============================================
- Hits 15144 11904 -3240
- Misses 4450 7850 +3400
+ Partials 1490 1330 -160 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Create issue for the fix.
And is this issue https://github.com/hugegraph/hugegraph/issues/838 related to openWithoutDB()
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlSessions.java
Outdated
Show resolved
Hide resolved
.setParameter("socketTimeout", | ||
String.valueOf(timeout)) | ||
.toString(); | ||
String url = this.buildUri(true, timeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the origin logic is autoReconnect=false and no database parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
autoReconnect really do not need, but need useSSL param
你好,请问下现在是怎么解决0.10.4版本openWithoutDB ssl-mode不起作用这个问题。现在初始化mysql一直报SSL这个问题。 |
@I-DO-NOT-KNOW 可以cherry-pick这个commit |
好的,谢谢 |
Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31
hugegraph-mysql/src/main/java/com/baidu/hugegraph/backend/store/mysql/MysqlSessions.java
Outdated
Show resolved
Hide resolved
Change-Id: I457247da404b2dea44f272e9eec60345baa048d6
* Fix mysql backend openWithoutDB ssl-mode not work Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31
* Fix mysql backend openWithoutDB ssl-mode not work (#842) * fix bug of missing offset with index query (#866) * allow system async task in gremlin context (#892) * sm allow cassandra backend creating thread as needed while execute cql (#896) * fix: Invalid limit 10000000, must be <= capacity (#950) * Fix gremlin-console can't work (#1027) Change-Id: Ice222d809e4161f1d4d1f04822bef1c5af380a10 Co-authored-by: Linary <liningrui@vip.qq.com> Co-authored-by: zhoney <zhangyi51@baidu.com>
Change-Id: I3bf5ef9deae121a51f4e1b4ce8132958194bde31