-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow system async task in gremlin context #892
Conversation
Change-Id: I5ec9e09ea366ff32b6460ff138d8412065da2ca4
@@ -64,6 +64,14 @@ | |||
"file.encoding" // PostgreSQL | |||
); | |||
|
|||
private static final Map<String, Set<String>> ASYNC_TASKS = ImmutableMap.of( | |||
"com.baidu.hugegraph.backend.tx.SchemaTransaction", | |||
ImmutableSet.of("rebuildIndex", "removeVertexLabel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put rebuildIndex to the fourth param
Change-Id: I6752230058bbcf4c8e8c76f4ba953ad1d6a90df7
Codecov Report
@@ Coverage Diff @@
## master #892 +/- ##
============================================
- Coverage 72.13% 72.11% -0.03%
- Complexity 4456 4457 +1
============================================
Files 287 287
Lines 21227 21231 +4
Branches 2992 2992
============================================
- Hits 15313 15310 -3
- Misses 4401 4408 +7
Partials 1513 1513
Continue to review full report at Codecov.
|
复现方式启动HugeGraphServer后,创建PK,VL、IL即可。 cause分析
由IndexLabel create出发rebuildIndex是系统内部的合理机制,SecurityManager应该允许。除了rebuildIndex外,还有以下合理的系统内部异步任务,这些都应该被允许创建Thread:
因此,修复方式为:SecurityManager允许系统内部的异步任务调度时创建Thread。
|
|
当查询会涉及多个host的时候,查询完当前host(当前链接)会按照执行计划尝试找下一个host进行查询(findNextHostAndQuery),这时按按需创建链接(executor创建Thread |
fixed: #892 Change-Id: I586eb64c90c475508247c3f8a39ae487598dd518
0.11 rocksdb
|
相关问题:#758 |
Change-Id: I5ec9e09ea366ff32b6460ff138d8412065da2ca4
* Fix mysql backend openWithoutDB ssl-mode not work (#842) * fix bug of missing offset with index query (#866) * allow system async task in gremlin context (#892) * sm allow cassandra backend creating thread as needed while execute cql (#896) * fix: Invalid limit 10000000, must be <= capacity (#950) * Fix gremlin-console can't work (#1027) Change-Id: Ice222d809e4161f1d4d1f04822bef1c5af380a10 Co-authored-by: Linary <liningrui@vip.qq.com> Co-authored-by: zhoney <zhangyi51@baidu.com>
Change-Id: I5ec9e09ea366ff32b6460ff138d8412065da2ca4
Change-Id: I5ec9e09ea366ff32b6460ff138d8412065da2ca4
fix: