sm allow cassandra backend creating thread as needed while execute cql #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed: #892 Change-Id: I586eb64c90c475508247c3f8a39ae487598dd518
|
没写测试用例，触发条件比较苛刻：需要后端是Cassandra集群，且单个查询涉及多个节点。 |
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
============================================
- Coverage 72.23% 72.23% -0.01%
+ Complexity 4487 4486 -1
============================================
Files 287 287
Lines 21411 21412 +1
Branches 3017 3017
============================================
Hits 15467 15467
Misses 4432 4432
- Partials 1512 1513 +1
Continue to review full report at Codecov.
|
javeme
reviewed
Mar 16, 2020
| ImmutableSet.of("open", "opened", "init"), | ||
| /* | ||
| * fixed https://github | ||
| * .com/hugegraph/hugegraph/pull/892#issuecomment-598545072 |
There was a problem hiding this comment.
keep on a line.
or move 892#issuecomment-598545072 to this pr and just add comment "fix #896"
javeme
approved these changes
Mar 16, 2020
Linary
approved these changes
Mar 16, 2020
Linary
added a commit
that referenced
this pull request
Jun 19, 2020
* Fix mysql backend openWithoutDB ssl-mode not work (#842) * fix bug of missing offset with index query (#866) * allow system async task in gremlin context (#892) * sm allow cassandra backend creating thread as needed while execute cql (#896) * fix: Invalid limit 10000000, must be <= capacity (#950) * Fix gremlin-console can't work (#1027) Change-Id: Ice222d809e4161f1d4d1f04822bef1c5af380a10 Co-authored-by: Linary <liningrui@vip.qq.com> Co-authored-by: zhoney <zhangyi51@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed: #892
Change-Id: I586eb64c90c475508247c3f8a39ae487598dd518
https://github.com/hugegraph/hugegraph/pull/892#issuecomment-598545072