Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] The checkstyle workflow is redundant #1436

Closed
shink opened this issue Aug 15, 2021 · 0 comments · Fixed by #1437
Closed

[CI] The checkstyle workflow is redundant #1436

shink opened this issue Aug 15, 2021 · 0 comments · Fixed by #1437
Labels
type/bug Something is wrong
Milestone

Comments

@shink
Copy link
Member

shink commented Aug 15, 2021

The checkstyle plugin is bound to Maven's validate phase. When execute mvn verify, code will be checked. So the checkstyle workflow is redundant.

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-checkstyle-plugin</artifactId>
  <version>3.1.1</version>
  <dependencies>
    <dependency>
      <groupId>com.puppycrawl.tools</groupId>
      <artifactId>checkstyle</artifactId>
      <version>8.29</version>
    </dependency>
  </dependencies>
  <executions>
    <execution>
      <id>checkstyle</id>
      <phase>validate</phase>
      <goals>
        <goal>check</goal>
      </goals>
    </execution>
  </executions>
</plugin>
shink added a commit to shink/inlong that referenced this issue Aug 15, 2021
@dockerzhang dockerzhang added this to the 0.10.0 milestone Aug 15, 2021
ApocalypseWan pushed a commit to ApocalypseWan/incubator-inlong that referenced this issue Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants