Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] RestTemplateConfig cannot load config from properties #1621

Closed
2 tasks done
ruanwenjun opened this issue Oct 13, 2021 · 0 comments · Fixed by #1622
Closed
2 tasks done

[Bug] RestTemplateConfig cannot load config from properties #1621

ruanwenjun opened this issue Oct 13, 2021 · 0 comments · Fixed by #1622
Assignees
@dockerzhang
Labels
component/manager type/bug Something is wrong
Milestone
0.11.0

Comments

@ruanwenjun
Copy link
Member

What happened

The RestTemplateConfig cannot load config from properties.

This caused by we need to add set method when using ConfigurationProperties.

https://github.com/apache/incubator-inlong/blob/6ca488190ae42dcf538410ef8334d4400562285f/inlong-manager/manager-web/src/main/java/org/apache/inlong/manager/web/config/RestTemplateConfig.java#L44-L72

What you expected to happen

Load config from proties.

How to reproduce

Modified the config maxTotal in properties, the RestTemplateConfig cannot load.

Environment

MacOs Big Sur Version 11.3.1

InLong version

master

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dockerzhang dockerzhang

Labels
component/manager type/bug Something is wrong
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

[INLONG-1621] Fix RestTemplateConfig cannot load config from properties ruanwenjun/incubator-inlong
2 participants
@dockerzhang @ruanwenjun