Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1826][Feature][InLong-Agent] Use jmx metric defined in inlong-common #1827

Merged
merged 2 commits into from
Nov 22, 2021

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Nov 22, 2021

[INLONG-1826][Feature][InLong-Agent] Use jmx metric defined in inlong-common

Fixes #1826

Motivation

The agent metric now cannot cope with the inlong-common metric
Should use jmx metric defined in inlong-common

Modifications

Use jmx metric defined in inlong-common

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (no)

@dockerzhang
Copy link
Contributor

@EMsnap there are some workflows that failed, please check again.
And after this PR merged, please add a guiding document like apache/inlong-website#187.

@codecov-commenter
Copy link

Codecov Report

Merging #1827 (d20f979) into master (2123611) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1827   +/-   ##
=========================================
  Coverage     11.53%   11.54%           
- Complexity     1049     1051    +2     
=========================================
  Files           400      400           
  Lines         34789    34789           
  Branches       5504     5504           
=========================================
+ Hits           4013     4016    +3     
+ Misses        30009    30007    -2     
+ Partials        767      766    -1     
Impacted Files Coverage Δ
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.51% <0.00%> (+0.44%) ⬆️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2123611...d20f979. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 3621195 into apache:master Nov 22, 2021
Copy link
Contributor Author

@EMsnap EMsnap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Use jmx metric defined in inlong-common
5 participants