Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][TubeMQ] repHelperHost for master should be exposed in configuration #1863

Closed
2 tasks done
aloyszhang opened this issue Nov 29, 2021 · 3 comments · Fixed by #1871
Closed
2 tasks done

[Improve][TubeMQ] repHelperHost for master should be exposed in configuration #1863

aloyszhang opened this issue Nov 29, 2021 · 3 comments · Fixed by #1871

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Nov 29, 2021

Description

Currently, repHelperHost in master.ini isn't exposed.
See https://github.com/apache/incubator-inlong/blob/master/inlong-tubemq/conf/master.ini?#L70

This is a key configuration for Tube master especially when you build a failover master service.

So, it should be exposed, also, we should add some guides for this configuration

InLong Component

InLong TubeMQ

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

@gosonzhang
Copy link
Contributor

@aloyszhang, you are right, the parameters of the copy are very important, and each copy group requires a different parameter configuration; commenting it out will make the outside mistakenly think that only the default value is needed.

@gosonzhang
Copy link
Contributor

Can you contribute a PR?

@aloyszhang
Copy link
Contributor Author

Yeah, I'll send a pull request soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants