You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I analyzed the metric implementation in the common module[1], and there are a few issues that need to be corrected, or they can’t be connected with the external standard JMX call.
a. To be implemented based on MXBean instead of MBean;
MBean can only provide the call of the basic class, and the composite class needs MXBean to define
b. The name format of the constructed Beanobject should be unified:
To be constructed based on ObjectName("XXXX:type=YYYYY") format, where XXXX and YYYYYare arbitrary, but ":type=" is a fixed format
c. Cannot only have get-and-reset() API:
If we only have the get-and-reset() API, when we look at Counter type indicators, we still need the caller to keep the previous data and accumulate it by itself, which is unreasonable.
What happened
I analyzed the metric implementation in the common module[1], and there are a few issues that need to be corrected, or they can’t be connected with the external standard JMX call.
a. To be implemented based on MXBean instead of MBean;
MBean can only provide the call of the basic class, and the composite class needs MXBean to define
b. The name format of the constructed Beanobject should be unified:
To be constructed based on ObjectName("XXXX:type=YYYYY") format, where XXXX and YYYYYare arbitrary, but ":type=" is a fixed format
c. Cannot only have get-and-reset() API:
If we only have the get-and-reset() API, when we look at Counter type indicators, we still need the caller to keep the previous data and accumulate it by itself, which is unreasonable.
What you expected to happen
Use standard JMX tools, for example, jconsole, for interface access
How to reproduce
Use standard JMX tools, for example, jconsole, for interface access
Environment
No response
InLong version
master
InLong Component
Other for not specified component
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: