Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Some questions about the metric implementation in the common module #1911

Closed
1 of 2 tasks
gosonzhang opened this issue Dec 6, 2021 · 0 comments · Fixed by #1918
Closed
1 of 2 tasks

[Bug] Some questions about the metric implementation in the common module #1911

gosonzhang opened this issue Dec 6, 2021 · 0 comments · Fixed by #1918
Labels
type/bug Something is wrong
Milestone

Comments

@gosonzhang
Copy link
Contributor

What happened

I analyzed the metric implementation in the common module[1], and there are a few issues that need to be corrected, or they can’t be connected with the external standard JMX call.
a. To be implemented based on MXBean instead of MBean;
MBean can only provide the call of the basic class, and the composite class needs MXBean to define
b. The name format of the constructed Beanobject should be unified:
To be constructed based on ObjectName("XXXX:type=YYYYY") format, where XXXX and YYYYYare arbitrary, but ":type=" is a fixed format
c. Cannot only have get-and-reset() API:
If we only have the get-and-reset() API, when we look at Counter type indicators, we still need the caller to keep the previous data and accumulate it by itself, which is unreasonable.

  1. https://github.com/apache/incubator-inlong/tree/master/inlong-common/src/main/java/org/apache/inlong/commons/config/metrics

What you expected to happen

Use standard JMX tools, for example, jconsole, for interface access

How to reproduce

Use standard JMX tools, for example, jconsole, for interface access

Environment

No response

InLong version

master

InLong Component

Other for not specified component

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant