[INLONG-755]Go SDK Consumer Result #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@charlely @gosonzhang PTAL |
Codecov Report
@@ Coverage Diff @@
## INLONG-25 #557 +/- ##
==============================================
+ Coverage 7.47% 7.51% +0.04%
- Complexity 477 479 +2
==============================================
Files 267 267
Lines 29500 29500
Branches 4843 4843
==============================================
+ Hits 2204 2216 +12
+ Misses 26822 26810 -12
Partials 474 474
Continue to review full report at Codecov.
|
charlely
reviewed
Jul 19, 2021
| @@ -383,7 +383,7 @@ func (c *consumer) processRebalanceEvent() { | |||
| } | |||
|
|
|||
| func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) { | |||
| log.Tracef("[disconnect2Broker] connect event begin, client id=%s", c.clientID) | |||
| log.Tracef("[disconnect2Broker] connect event begin, client=%s", c.clientID) | |||
There was a problem hiding this comment.
This is disconnect function, but this is concet event.
| @@ -393,7 +393,7 @@ func (c *consumer) disconnect2Broker(event *metadata.ConsumerEvent) { | |||
| } | |||
| } | |||
| event.SetEventStatus(metadata.Disconnect) | |||
| log.Tracef("[disconnect2Broker] connect event finished, client id=%s", c.clientID) | |||
| log.Tracef("[disconnect2Broker] connect event finished, client=%s", c.clientID) | |||
Signed-off-by: Zijie Lu <wslzj40@gmail.com>
charlely
approved these changes
Jul 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zijie Lu wslzj40@gmail.com