Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-788]Fix Go SDK Remote Cache Bug #586

Merged
merged 1 commit into from
Jul 23, 2021

Conversation

TszKitLo40
Copy link
Contributor

Fixes Jira Issue ID:
https://issues.apache.org/jira/browse/INLONG-788

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@TszKitLo40
Copy link
Contributor Author

@gosonzhang @charlely PTAL

@codecov-commenter
Copy link

Codecov Report

Merging #586 (69c29fb) into INLONG-25 (f711a68) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             INLONG-25    #586      +/-   ##
==============================================
+ Coverage         7.48%   7.51%   +0.02%     
  Complexity         479     479              
==============================================
  Files              267     267              
  Lines            29500   29500              
  Branches          4843    4843              
==============================================
+ Hits              2209    2216       +7     
+ Misses           26816   26810       -6     
+ Partials           475     474       -1     
Impacted Files Coverage Δ
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 55.42% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f711a68...69c29fb. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit c8e4eac into apache:INLONG-25 Jul 23, 2021
return
}
if pos >= 0 {
r.indexPartitions = append(r.indexPartitions[:pos], r.indexPartitions[pos+1:]...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need check pos is Last.
if len(r.indexPartitions) == 1 && pos == 0 {
r.indexPartitions = nil // Because always use append to add item.
}
if pos >= 0 {
....
}

xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
fix error in kafka doc
Co-authored-by: EMsnap <stingpeng@tencent.com>
Co-authored-by: EMsnap <zpengag@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants