Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-804] Optimize the ASF Configuration #595

Merged
merged 1 commit into from
Jul 27, 2021
Merged

[INLONG-804] Optimize the ASF Configuration #595

merged 1 commit into from
Jul 27, 2021

Conversation

dockerzhang
Copy link
Contributor

Fixes Jira Issue ID:
https://issues.apache.org/jira/projects/INLONG/issues/INLONG-804

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-commenter
Copy link

Codecov Report

Merging #595 (e656a5b) into master (c39b164) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #595      +/-   ##
===========================================
- Coverage      7.72%   7.71%   -0.01%     
+ Complexity      563     562       -1     
===========================================
  Files           355     355              
  Lines         31081   31081              
  Branches       4972    4972              
===========================================
- Hits           2400    2398       -2     
- Misses        28190   28195       +5     
+ Partials        491     488       -3     
Impacted Files Coverage Δ
...inlong/tubemq/manager/service/TaskServiceImpl.java 3.65% <0.00%> (-4.88%) ⬇️
...ong/tubemq/manager/service/ClusterServiceImpl.java 50.00% <0.00%> (-2.95%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 44.57% <0.00%> (+0.58%) ⬆️
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 40.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c39b164...e656a5b. Read the comment docs.

@dockerzhang dockerzhang merged commit c13f532 into apache:master Jul 27, 2021
ApocalypseWan pushed a commit to ApocalypseWan/incubator-inlong that referenced this pull request Aug 23, 2021
Co-authored-by: dockerzhang <dockerzhang@tencent.com>
xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants