Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment: New DRL parser : Better implementation switch #5683

Closed
tkobayas opened this issue Feb 9, 2024 · 1 comment
Closed

Experiment: New DRL parser : Better implementation switch #5683

tkobayas opened this issue Feb 9, 2024 · 1 comment
Assignees

Comments

@tkobayas
Copy link
Contributor

tkobayas commented Feb 9, 2024

Parent issue: #5678

#5677 (comment)

@mariofusco @yurloc Do you think it's fine to call the new parser DRL10? This doesn't introduce a new syntax, but we need a clear separation. So I use LanguageLevelOption. Feel free to share your thoughts.

Temporarily, yes. But it should be removed in the final step in my opinion.

  1. The language level stays the same. We're just changing an implementation detail that deals with how the source code in DRL6 language is being parsed.
  2. Is the language level option a public API? If yes, it's one more reason not to introduce DRL10. Implementation details should not proliferate to the public API.

Finally, we would like to use a better way for the implementation switch

@tkobayas
Copy link
Contributor Author

Done by #5693

Now we use system property switch drools.drl.antlr4.parser.enabled (true by default). No longer use DRL10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant