Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary warning when running Spring Boot application with DRL rules #394

Closed
baldimir opened this issue Jul 27, 2023 · 2 comments · Fixed by apache/incubator-kie-drools#5410
Assignees
Labels
area:engine Related to the runtime engines area:rules Related to Rules (DRL, DROOLS) type:bug Something is behaving unexpectedly

Comments

@baldimir
Copy link

When running a Spring Boot application that is built using spring-boot-maven-plugin, having drl files in BOOT-INF directory, an unnecessary warning is printed in the logs. Example: "File 'BOOT-INF/classes/rules/common/Sample.drl' is in folder 'BOOT-INF/classes/rules/common' but declares package 'rules.common'. It is advised to have a correspondance between package and folder names."

The source of this warning is here: https://github.com/kiegroup/drools/blob/0255407da604089adc57ad9b955b283915b0ecad/drools-compiler/src/main/java/org/drools/compiler/kie/builder/impl/KieBuilderImpl.java#L398

Acceptance criteria:

  • The warning is not printed in the logs when having drl files in BOOT-INF directory.
@baldimir baldimir self-assigned this Jul 27, 2023
@baldimir baldimir added area:engine Related to the runtime engines area:rules Related to Rules (DRL, DROOLS) type:bug Something is behaving unexpectedly labels Jul 27, 2023
@baldimir
Copy link
Author

baldimir commented Jul 27, 2023

This cannot be properly test with a simple test in Drools repository. Because of that I created a separate issue to properly test this: #395.

@baldimir
Copy link
Author

baldimir commented Aug 4, 2023

PRs merged, closing this.

@baldimir baldimir closed this as completed Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:engine Related to the runtime engines area:rules Related to Rules (DRL, DROOLS) type:bug Something is behaving unexpectedly
Projects
None yet
1 participant