Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

METRON-708: Update metron documentation #447

Closed
wants to merge 2 commits into from

Conversation

JonZeolla
Copy link
Member

Primarily these was an update of table formatting and fixing or improving links in documentation. However some important content was changed, as outlined below.

Noteworthy changes

  • Added a brew cask install java to fulfill a prerequisite of brew install maven for macOS install instructions.
  • Updated the “must be single quoted” table in metron-platform/metron-common/README.md. Previously, > was in a nonexistent fourth column, so it was not being properly displayed via the README.md, and the last row seemed to be a repeat.
    • Question: Should we add the in operator to the “must be single quoted” table?

Please do not merge this until the dev list conversation titled “Ansible 2.0.0.2 build issues” comes to a resolution (being sent out soon).

@JonZeolla
Copy link
Member Author

Would anybody be willing to update this picture? I don't believe we have MySQL doing the enrich as of this commit.

@cestella
Copy link
Member

@JonZeolla Good contribution! Thanks a lot.

I'd go ahead and document the workaround you proposed in the dev list regarding ansible 2.0.0.2. Also, if you don't want to modify the picture directly, I'd recommend making a separate JIRA for it and mentioning it independently on the dev list so it doesn't hold up your JIRA.

@mattf-apache
Copy link
Member

+1 on the changes so far, by inspection.

@cestella
Copy link
Member

@JonZeolla I suggest treating the PR as it stands to be complete and tracking the ansible and image portion in a follow-on JIRA. I'm +1 on it as it stands.

@JonZeolla
Copy link
Member Author

Ok sounds good to me, I will split those items out to a follow-on. This can be merged - thanks.

@asfgit asfgit closed this in f6c253f Feb 10, 2017
@JonZeolla JonZeolla deleted the METRON-708 branch February 11, 2017 19:02
@simonellistonball
Copy link
Contributor

Diagram updated in #452

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants