Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix mistyped variable name in mxnet_predict.py. #12211

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Fix mistyped variable name in mxnet_predict.py. #12211

merged 1 commit into from
Aug 17, 2018

Conversation

hqucms
Copy link
Contributor

@hqucms hqucms commented Aug 16, 2018

Description

This is to fix a mistyped variable name in amalgamation/python/mxnet_predict.py introduced by #11493.

Related to #8270.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@hqucms hqucms mentioned this pull request Aug 16, 2018
Closed
hqucms referenced this pull request Aug 16, 2018
@hqucms @marcoabreu
Fix MXPredReshape in the c_predict_api (#11493)
f3070fb 
* Fix MXPredReshape in the c_predict_api.

* Add unittest for the C predict API.

* Fix path in the test.

* Fix for Windows.

* Try again to fix for Windows.

* One more try to fix test on Windows.

* Try again with CI.

* Try importing from mxnet first if cannot find the amalgamation lib.

* Add a log message when libmxnet_predict.so is not found.

* Set specific rtol and atol values.

* Fix missing rtol and atol values.

* Empty commit.

* Try again with CI.

* One more try with CI.

* Retry CI.
sandeep-krishnamurthy
sandeep-krishnamurthy approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@sandeep-krishnamurthy sandeep-krishnamurthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contributions!

@sandeep-krishnamurthy sandeep-krishnamurthy merged commit 38bcb88 into apache:master Aug 17, 2018
marcoabreu added a commit that referenced this pull request Aug 17, 2018
@marcoabreu
Revert "Fix typo. (#12211)"
034b6f8 
This reverts commit 38bcb88.
piyushghai added a commit to piyushghai/incubator-mxnet that referenced this pull request Aug 17, 2018
@piyushghai
Revert "Fix typo. (apache#12211)"
0d21b9d 
This reverts commit 38bcb88.
XinYao1994 pushed a commit to XinYao1994/incubator-mxnet that referenced this pull request Aug 29, 2018
@hqucms @sandeep-krishnamurthy
Fix typo. (apache#12211)
9ecbabd
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vandanavk vandanavk vandanavk approved these changes

@cclauss cclauss cclauss approved these changes

@sandeep-krishnamurthy sandeep-krishnamurthy sandeep-krishnamurthy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hqucms @sandeep-krishnamurthy @cclauss @vandanavk