Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

add ffi full_like, binary ops, benchmark test #17811

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

Alicia1529
Copy link
Contributor

Description

add ffi invocation for full_like, subtract, divide, true_divide, mod, remainder, power, multiply

@Alicia1529 Alicia1529 requested a review from szha as a code owner March 11, 2020 07:03
@Alicia1529 Alicia1529 force-pushed the np_op_ffi_invocation_full_like branch from ede0722 to 10c3a21 Compare March 11, 2020 07:35
@haojin2 haojin2 added the Numpy label Mar 11, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Mar 11, 2020
@haojin2 haojin2 self-assigned this Mar 11, 2020
@haojin2
Copy link
Contributor

haojin2 commented Mar 12, 2020

@hzfan This PR looks good to you?

numpy automation moved this from In progress to Reviewer approved Mar 13, 2020
python/mxnet/ndarray/numpy/_op.py Outdated Show resolved Hide resolved
src/operator/tensor/init_op.h Outdated Show resolved Hide resolved
@Alicia1529 Alicia1529 force-pushed the np_op_ffi_invocation_full_like branch 2 times, most recently from 75ef186 to 96e24f9 Compare March 18, 2020 01:38
@Alicia1529 Alicia1529 closed this Mar 18, 2020
numpy automation moved this from Reviewer approved to Done Mar 18, 2020
@Alicia1529 Alicia1529 reopened this Mar 18, 2020
numpy automation moved this from Done to In progress Mar 18, 2020
@Alicia1529 Alicia1529 force-pushed the np_op_ffi_invocation_full_like branch from 96e24f9 to 797ec11 Compare March 18, 2020 03:45
numpy automation moved this from In progress to Reviewer approved Mar 18, 2020
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haojin2 haojin2 merged commit 2fae7e4 into apache:master Mar 18, 2020
numpy automation moved this from Reviewer approved to Done Mar 18, 2020
anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
No open projects
numpy
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants