This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
HybridBlock.export() to return created filenames (#17688) #17758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please fix
|
sergeykolychev
approved these changes
Mar 8, 2020
Friendly ping @athewsey regarding the linting issues |
Whoops, sorry! Should be there now |
leezu
approved these changes
Mar 18, 2020
rondogency
added a commit
to rondogency/incubator-mxnet
that referenced
this pull request
Mar 18, 2020
This reverts commit dfb1b88.
anirudh2290
added a commit
to anirudh2290/mxnet
that referenced
this pull request
Mar 27, 2020
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits) * impl - FFI for np einsum (apache#17869) [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789) [Numpy] Kron operator (apache#17323) cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878) Add simplified HybridBlock.forward without F (apache#17530) Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700) Use multi-tensor sumSQ in clip_global_norm (apache#17652) [Numpy] Add op fmax, fmin, fmod (apache#17567) Adding sparse support to MXTensor for custom operators (apache#17569) Update 3rdparty/mkldnn to v1.2.2 (apache#17313) Dynamic subgraph compile support (apache#17623) Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835) staticbuild: Fix potential user-assisted execution of arbitrary code (apache#17860) * FFI for np.argmax and np.argmin (apache#17843) ffi for roll/rot90 (apache#17861) Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797) add ffi for full_like, binary (apache#17811) HybridBlock.export() to return created filenames (apache#17758) Fix SoftReLU fused operator numerical stability (apache#17849) CI: Test clang10 cpu & gpu builds with -WError (apache#17830) ...
MoisesHer
pushed a commit
to MoisesHer/incubator-mxnet
that referenced
this pull request
Apr 10, 2020
* [Gluon] Return filenames from HybridBlock.export (apache#1579) * [Gluon] Unittest filenames from HybridBlock.export (apache#1579) * [Gluon] Perl HybridBlock.export return filenames (apache#1579) * [Gluon] HybridBlock.export docstring grammar fix * Linting - fix trailing whitespace
anirudh2290
pushed a commit
to anirudh2290/mxnet
that referenced
this pull request
May 29, 2020
* [Gluon] Return filenames from HybridBlock.export (apache#1579) * [Gluon] Unittest filenames from HybridBlock.export (apache#1579) * [Gluon] Perl HybridBlock.export return filenames (apache#1579) * [Gluon] HybridBlock.export docstring grammar fix * Linting - fix trailing whitespace
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minimum, non-breaking change to alleviate #17688
HybridBlock.export()
to return tuple of stored filenames (rather than undefined), to expose this information to user code which would otherwise have to re-implement internal filename selection logic.Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)(No JIRA issue, to my knowledge)Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)For new C++ functions in header files, their functionalities and arguments are documented.For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicableCheck the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.htmlChanges
Comments