Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Kron operator #17323

Merged
merged 4 commits into from
Mar 23, 2020
Merged

[Numpy] Kron operator #17323

merged 4 commits into from
Mar 23, 2020

Conversation

hanke580
Copy link
Contributor

@hanke580 hanke580 commented Jan 15, 2020 •
edited
Loading

Description

  • Add Kron operator
  • Including Forward and Backward

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

Performance comparisons (in microseconds):

Operator Official NumPy Legacy ctypes New ctypes New Cython
kron 14.42 21.46 16.73 8.92

@hanke580 hanke580 requested a review from szha as a code owner January 15, 2020 11:51
@hanke580 hanke580 requested a review from haojin2 January 15, 2020 11:52
@haojin2 haojin2 self-assigned this Jan 15, 2020
@haojin2 haojin2 added the Numpy label Jan 15, 2020
@haojin2 haojin2 added this to To Do in Tests Improvement via automation Jan 15, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Jan 15, 2020
@haojin2 haojin2 removed this from To Do in Tests Improvement Jan 15, 2020
haojin2
haojin2 reviewed Jan 15, 2020
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comments, fix the sanity errors and unit test errors.

@hanke580 hanke580 force-pushed the kron branch 4 times, most recently from 6fbff90 to 90429de Compare March 11, 2020 06:22
@hanke580 hanke580 force-pushed the kron branch 3 times, most recently from 2e8a445 to ed44489 Compare March 18, 2020 04:55
@hanke580
[Numpy]Add kron
24725e0 
* Implement the forward of Kron op

* Implement the Backward of a

* Implement the Backward of b

* Fix 3rd party

* Fix cpp sanity

* Finish grad check

* address comments: fix test_np_op and reduce req to req[0]
@hanke580
* Fix ndim = 0
a8054c5
@hanke580
* Fix uninitialize bugs
279d6af
@hanke580
* Impl FFI
aadb254
hzfan
hzfan reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in terms of FFI

@haojin2 haojin2 merged commit 9a355eb into apache:master Mar 23, 2020
numpy automation moved this from In progress to Done Mar 23, 2020
anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
@anirudh2290
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ae654ba 
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@hanke580 @MoisesHer
[Numpy] Kron operator (apache#17323)
93dc550 
* [Numpy]Add kron

* Implement the forward of Kron op

* Implement the Backward of a

* Implement the Backward of b

* Fix 3rd party

* Fix cpp sanity

* Finish grad check

* address comments: fix test_np_op and reduce req to req[0]

* * Fix  ndim  = 0

* * Fix uninitialize bugs

* * Impl FFI
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@hanke580 @anirudh2290
[Numpy] Kron operator (apache#17323)
a733998 
* [Numpy]Add kron

* Implement the forward of Kron op

* Implement the Backward of a

* Implement the Backward of b

* Fix 3rd party

* Fix cpp sanity

* Finish grad check

* address comments: fix test_np_op and reduce req to req[0]

* * Fix  ndim  = 0

* * Fix uninitialize bugs

* * Impl FFI
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@hanke580 @sxjscience
[Numpy] Kron operator (apache#17323)
20f70e4 
* [Numpy]Add kron

* Implement the forward of Kron op

* Implement the Backward of a

* Implement the Backward of b

* Fix 3rd party

* Fix cpp sanity

* Finish grad check

* address comments: fix test_np_op and reduce req to req[0]

* * Fix  ndim  = 0

* * Fix uninitialize bugs

* * Impl FFI
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 left review comments

@hzfan hzfan hzfan left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanke580 @haojin2 @hzfan