Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] FFI: diag/diagonal/diag_indices_from #17789

Merged
merged 3 commits into from
Mar 24, 2020
Merged

[Numpy] FFI: diag/diagonal/diag_indices_from #17789

merged 3 commits into from
Mar 24, 2020

Conversation

Tommliu
Copy link
Contributor

@Tommliu Tommliu commented Mar 9, 2020 •
edited
Loading

Description

FFI imperative invocation for operator diag/diagonal/diag_indices_from

Numpy Operator Old FFI (ctypes) (us) New FFI (cython) (us)
diag 23.96 8.14
diagonal 29.5 8.82
diag_indices_from 48.95 46.97

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner March 9, 2020 03:50
@haojin2 haojin2 self-assigned this Mar 9, 2020
@haojin2 haojin2 added the Numpy label Mar 9, 2020
@haojin2 haojin2 added this to In progress in numpy via automation Mar 9, 2020
@Tommliu Tommliu force-pushed the ffi_diag branch 2 times, most recently from 88adb97 to 7cc1dbf Compare March 10, 2020 07:36
haojin2
haojin2 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@haojin2 haojin2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

numpy automation moved this from In progress to Reviewer approved Mar 13, 2020
@haojin2 haojin2 merged commit d4052fd into apache:master Mar 24, 2020
numpy automation moved this from Reviewer approved to Done Mar 24, 2020
@Tommliu Tommliu deleted the ffi_diag branch March 24, 2020 13:25
anirudh2290 added a commit to anirudh2290/mxnet that referenced this pull request Mar 27, 2020
@anirudh2290
Merge branch 'master' of https://github.com/apache/incubator-mxnet
ae654ba 
* 'master' of https://github.com/apache/incubator-mxnet: (192 commits)
  * impl - FFI for np einsum (apache#17869)
  [Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
  [Numpy] Kron operator (apache#17323)
  cmake: Set DMLC_LOG_FATAL_THROW only for building mxnet and not for tvm (apache#17878)
  Add simplified HybridBlock.forward without F (apache#17530)
  Use FP32 copy of weights for norm (multitensor LAMB optimizer) (apache#17700)
  Use multi-tensor sumSQ in clip_global_norm (apache#17652)
  [Numpy] Add op fmax, fmin, fmod (apache#17567)
  Adding sparse support to MXTensor for custom operators (apache#17569)
  Update 3rdparty/mkldnn to v1.2.2 (apache#17313)
  Dynamic subgraph compile support (apache#17623)
  Refactor cpp-package CMakeLists.txt & add missing inference/imagenet_inference (apache#17835)
  staticbuild: Fix potential user-assisted execution of arbitrary code  (apache#17860)
  * FFI for np.argmax and np.argmin (apache#17843)
  ffi for roll/rot90 (apache#17861)
  Skip test_multi_worker_dataloader_release_pool on OS X (apache#17797)
  add ffi for full_like, binary (apache#17811)
  HybridBlock.export() to return created filenames (apache#17758)
  Fix SoftReLU fused operator numerical stability (apache#17849)
  CI: Test clang10 cpu & gpu builds with -WError (apache#17830)
  ...
MoisesHer pushed a commit to MoisesHer/incubator-mxnet that referenced this pull request Apr 10, 2020
@Tommliu @MoisesHer
[Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
4bc950b 
* ffi_diag/diagonal/diag_indices_from

* sanity && benchmark
anirudh2290 pushed a commit to anirudh2290/mxnet that referenced this pull request May 29, 2020
@Tommliu @anirudh2290
[Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
8faed13 
* ffi_diag/diagonal/diag_indices_from

* sanity && benchmark
sxjscience pushed a commit to sxjscience/mxnet that referenced this pull request Jul 1, 2020
@Tommliu @sxjscience
[Numpy] FFI for diag/diagonal/diag_indices_from (apache#17789)
27d5008 
* ffi_diag/diagonal/diag_indices_from

* sanity && benchmark
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzfan hzfan hzfan left review comments

@haojin2 haojin2 haojin2 approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees

@haojin2 haojin2

Labels
Numpy
Projects
No open projects
numpy
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Tommliu @haojin2 @hzfan