Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DO NOT MERGE] Enable Large Tensor Support : Stage2 #18626

Closed
wants to merge 1 commit into from

Conversation

access2rohit
Copy link
Contributor

@access2rohit access2rohit commented Jun 27, 2020

Description

This PR enables Large Tensor Support(LTS) by default on master for platforms that were not covered by #18625.
DO NOT MERGE BEFORE THIS PR: #18625

Progress of Large Tensor Support tracked here: #17331

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, clang, unix-cpu, windows-gpu, centos-cpu, sanity, windows-cpu, miscellaneous, centos-gpu, edge, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jun 27, 2020
@access2rohit
Copy link
Contributor Author

@leezu @ChaiBapchya @josephevans Please review

@access2rohit
Copy link
Contributor Author

Not required as I have already enabled large tensor by default #18625

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants