Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pid_t: unify usage of special task IDs #5819

Merged
merged 1 commit into from
Mar 22, 2022
Merged

pid_t: unify usage of special task IDs #5819

merged 1 commit into from
Mar 22, 2022

Conversation

pkarashchenko
Copy link
Contributor

Summary

Unify usage of special task IDs

Impact

None. Refactoring only

Testing

Pass CI

@pkarashchenko pkarashchenko force-pushed the unify_pid branch 2 times, most recently from 5ace49c to b2cfa86 Compare March 21, 2022 23:20
xiaoxiang781216
xiaoxiang781216 reviewed Mar 22, 2022
View reviewed changes
include/nuttx/sched.h Show resolved Hide resolved
drivers/syslog/syslog_device.c Outdated Show resolved Hide resolved
drivers/syslog/syslog_device.c Outdated Show resolved Hide resolved
drivers/syslog/syslog_device.c Outdated Show resolved Hide resolved
@pkarashchenko pkarashchenko marked this pull request as draft March 22, 2022 09:46
@pkarashchenko pkarashchenko marked this pull request as ready for review March 22, 2022 10:27
@pkarashchenko
pid_t: unify usage of special task IDs
96d9e7c 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
gustavonihei
gustavonihei approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@gustavonihei gustavonihei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made one comment for improving consistency, but overall LGTM.

@gustavonihei
Copy link
Contributor

By the way, nice work @pkarashchenko!
It is a pleasure to see these inconsistencies being fixed throughout the NuttX code base.

@xiaoxiang781216 xiaoxiang781216 merged commit 68902d8 into apache:master Mar 22, 2022
@pkarashchenko pkarashchenko deleted the unify_pid branch March 31, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavonihei gustavonihei gustavonihei approved these changes

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@Ouss4 Ouss4 Awaiting requested review from Ouss4

@acassis acassis Awaiting requested review from acassis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkarashchenko @gustavonihei @xiaoxiang781216