Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/arm: Remove FAR and CODE from common/ and arm*/ folder #6093

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

Style change only

Impact

Minor

Testing

Pass CI

@xiaoxiang781216 xiaoxiang781216 changed the title arch/arm: Remove FAR from common/ and arm*/ folder arch/arm: Remove FAR and CODE from common/ and arm*/ folder Apr 18, 2022
@xiaoxiang781216
Copy link
Contributor Author

@pkarashchenko macOS CI always fail to:
" wget --quiet https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-apple-darwin.tar.gz"
Let's ignore this error temporarily?

@pkarashchenko
Copy link
Contributor

Yeah. Error code: SEC_ERROR_EXPIRED_CERTIFICATE. Seems like SiFive have to renew certficates

arch/arm/include/arch.h Outdated Show resolved Hide resolved
arch/arm/src/common/arm_backtrace_thumb.c Outdated Show resolved Hide resolved
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@pkarashchenko
Copy link
Contributor

Maybe we can issue a migration to https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz when certs are getting renewed.

@pkarashchenko
Copy link
Contributor

@xiaoxiang781216 do you consider we can add --no-check-certificate as a workaround to get CI running? Or just wait assuming that SiFive will renew certs soon?

@xiaoxiang781216
Copy link
Contributor Author

Maybe we can issue a migration to https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz when certs are getting renewed.

let's upgrade to the new version:)?

@pkarashchenko
Copy link
Contributor

Maybe we can issue a migration to https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz when certs are getting renewed.

let's upgrade to the new version:)?

The new version link also suffers same certificate expiration now :)

@xiaoxiang781216
Copy link
Contributor Author

Maybe we can issue a migration to https://static.dev.sifive.com/dev-tools/freedom-tools/v2020.12/riscv64-unknown-elf-toolchain-10.2.0-2020.12.8-x86_64-apple-darwin.tar.gz when certs are getting renewed.

let's upgrade to the new version:)?

The new version link also suffers same certificate expiration now :)

Ok, I added --no-check-certificate in #6094 to workaround it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants