Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arch/armv7-[a|r]: correct the handing of group env switch #6099

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Apr 19, 2022

Summary

arch/armv7-[a|r]: correct the handing of group env switch

This PR resolved 2 issues:

  1. CURRENT_REGS is not set correctly on swint handling
  2. group env is not changed properly

Signed-off-by: chao.an anchao@xiaomi.com

Fix bug reported by @masayuki2009 :
#6096 (comment)

Impact

kernel mode of armv7a/r

Testing

sabre-6quad/knsh

This PR resolved 2 issues:
1. CURRENT_REGS is not set correctly on swint handling
2. group env is not changed properly

Signed-off-by: chao.an <anchao@xiaomi.com>
@masayuki2009
Copy link
Contributor

@anchao

I confirmed that this PR fixes the issue reported in #6096 (comment)

@xiaoxiang781216
Copy link
Contributor

@masayuki2009 your automation test is very useful to detect the bug, do you plan to improve our ci to cover some basic testing? so we can catch it in the first place.

@pkarashchenko pkarashchenko merged commit b110c98 into apache:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants