Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

risc-v: Move common memory map to its own file from riscv_internal #6502

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

pussuw
Copy link
Contributor

@pussuw pussuw commented Jun 23, 2022

Move the linker defined symbols to a separate file, so they can be
accessed without pulling in everything from riscv_internal.h and
whatever it includes (e.g. syscall.h drags in a lot).

Summary

Split the linker defined symbols from riscv_internal.h. Main reason is to allow the xxx_memorymap.h files to include this instead of pulling in the entire riscv_internal.h file (and what it includes)

Impact

Minor refactoring

Testing

icicle

@pussuw
Copy link
Contributor Author

pussuw commented Jun 23, 2022

Don't think the error is my doing

curl: (28) Failed to connect to www.phyplusinc.com port 80: Connection timed out
cp: cannot stat 'libphy62xxble.a': No such file or directory
make[1]: *** [chip/Make.defs:82: .buildlib] Error 1
make[1]: Target 'context' not remade because of errors.
make: *** [tools/Unix.mk:425: arch/arm/src/.context] Error 2
make: Target 'all' not remade because of errors.

@acassis
Copy link
Contributor

acassis commented Jun 23, 2022

Don't think the error is my doing

curl: (28) Failed to connect to www.phyplusinc.com port 80: Connection timed out
cp: cannot stat 'libphy62xxble.a': No such file or directory
make[1]: *** [chip/Make.defs:82: .buildlib] Error 1
make[1]: Target 'context' not remade because of errors.
make: *** [tools/Unix.mk:425: arch/arm/src/.context] Error 2
make: Target 'all' not remade because of errors.

It is not! Maybe we need to have some mirror to avoid these sites disappear and we miss the closed source/proprietary libraries...

@pussuw
Copy link
Contributor Author

pussuw commented Jun 27, 2022

The fix for the build error is here:
#6530

@pkarashchenko pkarashchenko self-requested a review June 27, 2022 15:56
Move the linker defined symbols to a separate file, so they can be
accessed without pulling in everything from riscv_internal.h and
whatever it includes (e.g. syscall.h drags in a lot).
@pkarashchenko pkarashchenko merged commit cfebb5a into apache:master Jun 28, 2022
@pussuw pussuw deleted the riscv_internal_split branch June 28, 2022 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants