drivers/lcd: getplaneinfo fix for ST7789,ST7565 and skeleton driver #6526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxiang781216
approved these changes
Jun 26, 2022
pkarashchenko
approved these changes
Jun 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #6465, the new member
struct lcd_dev_s *devis added tostruct lcd_planeinfo_s.The member must be initialized in getplaneinfo method. But ST7789, ST7768 and skeleton LCD drivers lacks it.
The
raspberrypi-pico:displaypackconfiguration crashes because of this problem.This PR fixes it.
Impact
Every target using ST7789 and ST7567 LCD controllers.
Testing
raspberrypi-pico:displaypackworks.