ESP32-S2: Improvements to the GPIO driver #6540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Sync driver interfaces, also fixes the handling of special pin value for esp32s2_gpio_matrix_in and esp32s2_gpio_matrix_out functions Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
gustavonihei
force-pushed
the
bugfix/esp32s2_gpio
branch
from
d88f5b9
to
545fbb8
Compare
pkarashchenko
approved these changes
Jun 29, 2022
xiaoxiang781216
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR intends to fix the number of GPIO IRQs on the ESP32-S2.
Also, it brings an improvement to the documentation of the GPIO driver interface and to the overall code quality of the driver implementation.
Impact
gpio_intrtype_ttype has been changed fromuint8_ttoenum gpio_intrtype_e, with new identifiers for each enum item.This might affect users with custom boards based on ESP32-S2 chips.
Testing
Validated with
esp32s2-saola-1during development of the I2C driver on #6539