Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Adjust default value of bucket to -1 #2829

Merged
merged 20 commits into from
Feb 1, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

The behavior of defaulting to bucket 1 is not good. It forcibly limits the single parallelism processing and is not distributed processing at all, which is not conducive to users using it out of the box.

So this PR modifies this default value to -1. But we should pay attention to compatibility issues.

Tests

API and Format

For table without bucket option:

  • New table:
    • New Read&Write: Default bucket will be -1.
    • Old Read&Write: There will be problems.
  • Old table:
    • New Read&Write: Introduce version to TableSchema, old version schema will be added bucket = 1.
    • Old Read&Write: Nothing change.

Documentation

@JingsongLi JingsongLi closed this Jan 31, 2024
@JingsongLi JingsongLi reopened this Jan 31, 2024
Copy link
Contributor

@yuzelin yuzelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 4b667aa into apache:master Feb 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants