Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove version #36

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Remove version #36

merged 1 commit into from
Oct 17, 2023

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning mentioned this pull request Oct 15, 2023
Closed
Roiocam
Roiocam approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Roiocam Roiocam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjfanning
Copy link
Contributor Author

@mdedetrich would you be able to review this when you get a chance?

mdedetrich
mdedetrich approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pjfanning pjfanning merged commit 9585a66 into main Oct 17, 2023
@pjfanning pjfanning deleted the remove-version branch October 17, 2023 11:52
@pjfanning pjfanning mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Roiocam Roiocam Roiocam approved these changes

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @mdedetrich @Roiocam