[QueryContext] Use QueryContext in functions #5613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
query_context_function
branch
from
1a6b859
to
e3f2868
Compare
|
@mayankshriv Can you please review the change in |
Replace BrokerRequest classes (AggregationInfo, TransformExpressionTree) with QueryContext classes (FunctionContext, ExpressionContext) for aggregation and transform functions
Jackie-Jiang
force-pushed
the
query_context_function
branch
from
e3f2868
to
aeac8f4
Compare
mayankshriv
approved these changes
Jun 26, 2020
...pache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java
Show resolved
Hide resolved
siddharthteotia
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace
BrokerRequestclasses (AggregationInfo,TransformExpressionTree) with QueryContext classes (FunctionContext,ExpressionContext) for aggregation and transform functionsThis is the last PR of removing
BrokerRequestclasses from the query execution path. After this PR, the query engine will be independent ofBrokerRequestand only accessQueryContextclasses, and all the redundant expression parsing will be saved.Besides replacing
BrokerRequestclasses, also refactoredDistinctCountThetaSketchAggregationFunctionto use theQueryContextclasses, which solves the TODO of standardizing the predicate strings and simplifies the predicate handling.Minor bug-fixes:
BaseBrokerRequestHandler)DistinctCountRawThetaSketch(InBrokerRequestToQueryContextConverter)*forCOUNTwhen convertingFunctionCallAstNodetoFunctionContext(InQueryContextConverterUtils)Upgrade Notes
Because of the standardization of the
DistinctCountThetaSketchpredicate strings, please upgrade Broker before Server. The new Broker can handle both standard and non-standard predicate strings for backward-compatibility.