Fixing a backward compatible issue of converting BrokerRequest to QueryContext when querying from Presto segment splits #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryContext when querying from Presto segment splits
xiangfu0
force-pushed
the
backward_compatible_presto_select_query
branch
from
e91a6d9
to
bd23986
Compare
Jackie-Jiang
approved these changes
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Presto generates and sends segment level query directly to Pinot Servers.
The BrokerRequest sent only set LIMIT inside the Selections object.
Below is a sample converted QueryContext before this change, the Presto generated BrokerRequest is embedded in the
QueryContext.