Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BYTES type for DictinctCount aggregation function #5701

Merged
merged 1 commit into from
Jul 14, 2020
Merged

Support BYTES type for DictinctCount aggregation function #5701

merged 1 commit into from
Jul 14, 2020

Conversation

Jackie-Jiang
Copy link
Contributor

Description

Support BYTES type for DistinctCount aggregation function.

Changes:

  • Add BYTES type support to DistinctCountAggregationFunction
  • Correctly handle BYTES type in DictionaryBasedAggregationOperator for DistinctCount
  • In order to correctly handle BYTES type in DictionaryBasedAggregationOperator, add getValueType() into the Dictionary interface
  • Add DistinctCountQueriesTest to test DistinctCount queries on all data types

@Jackie-Jiang Jackie-Jiang mentioned this pull request Jul 14, 2020
Closed
kishoreg
kishoreg approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@kishoreg kishoreg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple. Thanks for the quick fix and adding the test case

@Jackie-Jiang Jackie-Jiang merged commit e5ddff4 into apache:master Jul 14, 2020
@Jackie-Jiang Jackie-Jiang deleted the distinct_count_bytes branch July 14, 2020 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kishoreg kishoreg kishoreg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jackie-Jiang @kishoreg