-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Pinot Minion client #6339
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6339 +/- ##
===========================================
- Coverage 66.44% 45.53% -20.91%
===========================================
Files 1075 1285 +210
Lines 54773 62034 +7261
Branches 8168 9001 +833
===========================================
- Hits 36396 28250 -8146
- Misses 15700 31475 +15775
+ Partials 2677 2309 -368
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise.
Minion is not ready to be used out of the box, and the APIs are subject to be changed. Not sure if we should add the client now, or hold until minion is ready
import org.testng.annotations.Test; | ||
|
||
|
||
public class MinionClientTest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is not actually testing the functionality as the response is hard-coded within the test. You may modify the minion integration test to test against the controller.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
this is a good question, I will comment and make it a test feature I guess. I feel it would be good to have it and it's ok to change it and deprecate the methods in the future. |
Description
Adding Pinot Minion client to operate on controller /tasks APIs.