Real-time json index #6408
Merged
Real-time json index #6408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackie-Jiang
force-pushed
the
json_realtime
branch
from
5489ae3
to
cf2d195
Compare
Codecov Report
@@ Coverage Diff @@
## master #6408 +/- ##
==========================================
- Coverage 66.44% 65.02% -1.43%
==========================================
Files 1075 1319 +244
Lines 54773 64301 +9528
Branches 8168 9361 +1193
==========================================
+ Hits 36396 41810 +5414
- Misses 15700 19512 +3812
- Partials 2677 2979 +302
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
approved these changes
Jan 6, 2021
| @@ -233,8 +233,8 @@ public void deleteSegmentFile() { | |||
| private final SegmentVersion _segmentVersion; | |||
| private final SegmentBuildTimeLeaseExtender _leaseExtender; | |||
| private SegmentBuildDescriptor _segmentBuildDescriptor; | |||
| private StreamConsumerFactory _streamConsumerFactory; | |||
| private StreamPartitionMsgOffsetFactory _streamPartitionMsgOffsetFactory; | |||
| private final StreamConsumerFactory _streamConsumerFactory; | |||
There was a problem hiding this comment.
do we need final for these ?
There was a problem hiding this comment.
Hmm, seems these are changed by the IDE auto-formatter
| public void onOpen(Session session, EndpointConfig config) { | ||
| session.addMessageHandler(new MessageHandler.Whole<String>() { | ||
| @Override | ||
| public void onMessage(String message) { |
There was a problem hiding this comment.
can we extend MeetupRsvpStream and override a method to generate the msg to produce?
There was a problem hiding this comment.
Good point, let me add that
Jackie-Jiang
force-pushed
the
json_realtime
branch
from
cf2d195
to
4bcdbce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add json index support to mutable (real-time) segments
Add a new quickstart for real-time json index on meetup RSVP events
Example query: Find events that are in the fitness group
select json_extract_scalar(event, '$.event_name', 'STRING') from meetupRsvp where json_match("group", 'group_topics.topic_name=''Fitness''') limit 10