Adding cluster config to config number of concurrent tasks per instance for minion task: SegmentGenerationAndPushTaskGenerator #6468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TaskGenerator number of concurrent tasks per instance
icefury71
approved these changes
Jan 20, 2021
...troller/src/main/java/org/apache/pinot/controller/helix/core/minion/ClusterInfoAccessor.java
Outdated
Show resolved
Hide resolved
...ache/pinot/controller/helix/core/minion/generator/SegmentGenerationAndPushTaskGenerator.java
Outdated
Show resolved
Hide resolved
| @Override | ||
| public int getNumConcurrentTasksPerInstance() { | ||
| String numConcurrentTasksPerInstance = _clusterInfoAccessor | ||
| .getClusterConfig(MinionConstants.SegmentGenerationAndPushTask.CONFIG_NUMBER_CONCURRENT_TASKS_PER_INSTANCE); |
There was a problem hiding this comment.
maybe use static import ?
There was a problem hiding this comment.
yeah, I just keep the same convention as in this file. Maybe good to have another PR to swipe all the conventions ;)
xiangfu0
force-pushed
the
adding_cluster_config_for_minion_SegmentGenerationAndPushTaskGenerator
branch
3 times, most recently
from
76e299e
to
fd21423
Compare
xiangfu0
force-pushed
the
adding_cluster_config_for_minion_SegmentGenerationAndPushTaskGenerator
branch
from
fd21423
to
9122244
Compare
Codecov Report
@@ Coverage Diff @@
## master #6468 +/- ##
===========================================
- Coverage 66.44% 43.82% -22.63%
===========================================
Files 1075 1332 +257
Lines 54773 65318 +10545
Branches 8168 9522 +1354
===========================================
- Hits 36396 28624 -7772
- Misses 15700 34302 +18602
+ Partials 2677 2392 -285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Jackie-Jiang
approved these changes
Jan 21, 2021
...troller/src/main/java/org/apache/pinot/controller/helix/core/minion/ClusterInfoAccessor.java
Outdated
Show resolved
Hide resolved
...troller/src/main/java/org/apache/pinot/controller/helix/core/minion/ClusterInfoAccessor.java
Outdated
Show resolved
Hide resolved
pinot-core/src/main/java/org/apache/pinot/core/common/MinionConstants.java
Outdated
Show resolved
Hide resolved
xiangfu0
deleted the
adding_cluster_config_for_minion_SegmentGenerationAndPushTaskGenerator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SegmentGenerationAndPushTask.numConcurrentTasksPerInstanceto config number of concurrent tasks per instance for minion task: SegmentGenerationAndPushTaskGenerator