-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade zookeeper version to 3.5.8 #6558
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
upgrade_zk_version
branch
from
February 9, 2021 01:35
78923dd
to
4039c0d
Compare
xiangfu0
changed the title
Upgrade zookeeper version from 3.4.11 to 3.4.13
Upgrade zookeeper version from 3.4.11 to 3.5.8
Feb 9, 2021
xiangfu0
force-pushed
the
upgrade_zk_version
branch
11 times, most recently
from
February 9, 2021 07:59
a6fa70c
to
e7a5b4b
Compare
xiangfu0
changed the title
Upgrade zookeeper version from 3.4.11 to 3.5.8
Upgrade zookeeper version
Feb 9, 2021
xiangfu0
force-pushed
the
upgrade_zk_version
branch
from
February 9, 2021 09:44
e7a5b4b
to
376a899
Compare
xiangfu0
force-pushed
the
upgrade_zk_version
branch
6 times, most recently
from
February 10, 2021 06:43
b773e81
to
ea0d605
Compare
xiangfu0
changed the title
Upgrade zookeeper version
Upgrade zookeeper version to 3.5.8
Feb 10, 2021
xiangfu0
requested review from
Jackie-Jiang,
jackjlli,
kishoreg and
mayankshriv
February 10, 2021 08:03
pinot-common/src/main/java/org/apache/pinot/common/utils/ZkStarter.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
upgrade_zk_version
branch
from
February 10, 2021 21:23
ea0d605
to
d1c9029
Compare
Jackie-Jiang
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
xiangfu0
force-pushed
the
upgrade_zk_version
branch
from
February 11, 2021 07:38
d1c9029
to
ab35518
Compare
xiangfu0
force-pushed
the
upgrade_zk_version
branch
from
February 11, 2021 07:42
ab35518
to
1e6e49a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #6554, upgrade zookeeper version from 3.4.11 to 3.5.8 to fix:
ZOOKEEPER-2184 : Zookeeper Client should re-resolve hosts when connection attempts fail.
Note:
org.apache.zookeeper.server.ZooKeeperServerMain
added an AdminServer, so there is one more exception in the throw list.Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
backward-incompat
, and complete the section below on Release Notes)Does this PR fix a zero-downtime upgrade introduced earlier?
backward-incompat
, and complete the section below on Release Notes)Does this PR otherwise need attention when creating release notes? Things to consider:
release-notes
and complete the section on Release Notes)Release Notes
If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.
If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text
Documentation
If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document