Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zookeeper version to 3.5.8 #6558

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Upgrade zookeeper version to 3.5.8 #6558

merged 1 commit into from
Feb 11, 2021

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Feb 8, 2021

Description

Per #6554, upgrade zookeeper version from 3.4.11 to 3.5.8 to fix:
ZOOKEEPER-2184 : Zookeeper Client should re-resolve hosts when connection attempts fail.

Note:

  • Found an issue on Zookeeper v3.4.13 running on JDK 14+ with an unresolvable hostname issue, so directly jump to 3.5.8.
  • From zookeeper 3.5.x, org.apache.zookeeper.server.ZooKeeperServerMain added an AdminServer, so there is one more exception in the throw list.
  • From zookeeper 3.5.x, ZK client will fail the initialization immediately if ZK server is unreachable, so ZkStarter needs to catch the exception and retry.

Upgrade Notes

Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)

  • Yes (Please label as backward-incompat, and complete the section below on Release Notes)

Does this PR fix a zero-downtime upgrade introduced earlier?

  • Yes (Please label this as backward-incompat, and complete the section below on Release Notes)

Does this PR otherwise need attention when creating release notes? Things to consider:

  • New configuration options
  • Deprecation of configurations
  • Signature changes to public methods/interfaces
  • New plugins added or old plugins removed
  • Yes (Please label this PR as release-notes and complete the section on Release Notes)

Release Notes

If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release.

If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text

Documentation

If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document

@xiangfu0 xiangfu0 changed the title Upgrade zookeeper version from 3.4.11 to 3.4.13 Upgrade zookeeper version from 3.4.11 to 3.5.8 Feb 9, 2021
@xiangfu0 xiangfu0 force-pushed the upgrade_zk_version branch 11 times, most recently from a6fa70c to e7a5b4b Compare February 9, 2021 07:59
@xiangfu0 xiangfu0 changed the title Upgrade zookeeper version from 3.4.11 to 3.5.8 Upgrade zookeeper version Feb 9, 2021
@apache apache deleted a comment from codecov-io Feb 9, 2021
@xiangfu0 xiangfu0 force-pushed the upgrade_zk_version branch 6 times, most recently from b773e81 to ea0d605 Compare February 10, 2021 06:43
@xiangfu0 xiangfu0 changed the title Upgrade zookeeper version Upgrade zookeeper version to 3.5.8 Feb 10, 2021
@apache apache deleted a comment from codecov-io Feb 10, 2021
@xiangfu0 xiangfu0 requested a review from snleee February 10, 2021 08:03
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise

@xiangfu0 xiangfu0 merged commit 4effcf9 into master Feb 11, 2021
@xiangfu0 xiangfu0 deleted the upgrade_zk_version branch February 11, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zookeeper client version so zookeeper client will re-resolve hosts when IP has changed
2 participants