RATIS-758. Illegal state transition in LeaderElection: RUNNING to CLOSED #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs another update to avoid |
|
The third commit fixes |
|
@szetszwo @bshashikant please review when you have some time |
|
@adoroszlai , please post the patch in the JIRA. Jenkins is not yet working with Ratis. |
|
Closed by c0721c1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make sure
LeaderElectionis transitioned toCLOSEDviaCLOSING. Even ifaskForVoteshas no chance for any iteration due to already being changed to follower.The first commit contains repro code, and can be dropped or reworked, eg. if mocking or exposing some methods only for testing is not desirable.
The second commit is the fix itself.
https://issues.apache.org/jira/browse/RATIS-758
How was this patch tested?
Added unit test case to reproduce the problem and verify the fix. Currently running all tests to check for regressions.