RATIS-832. Add Metrics for retry cache #58
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bshashikant Could you help review this patch ? Thank you very much. |
|
Thanks @runzhiwang . PR model doesn't yet work seamlessly in RATiS. Can you update the patch |
|
@bshashikant Yes, I have updated the patch on the jira. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not implement metric for cache size in bytes. Because
com.google.common.cache.Cachedoes not have the API to get the cache size. If I implement it myself, it will not be accurate, because the cache size depends on the data structure used bycom.google.common.cache.Cache.