Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:modify the error configuration name #2361

Merged
merged 11 commits into from
Mar 7, 2020

Conversation

funky-eyes
Copy link
Contributor

@funky-eyes funky-eyes commented Mar 5, 2020

Ⅰ. Describe what this PR did

modify the error configuration name

Ⅱ. Does this pull request fix one issue?

#2363

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@funky-eyes
Copy link
Contributor Author

@zjinlei @xingfudeshi @slievrly PTAL

@codecov-io
Copy link

codecov-io commented Mar 5, 2020

Codecov Report

Merging #2361 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop   #2361      +/-   ##
============================================
- Coverage      51.62%   51.6%   -0.02%     
+ Complexity      2695    2693       -2     
============================================
  Files            517     517              
  Lines          16733   16734       +1     
  Branches        1994    2039      +45     
============================================
- Hits            8638    8636       -2     
- Misses          7263    7290      +27     
+ Partials         832     808      -24
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/seata/server/store/StoreConfig.java 83.33% <100%> (ø) 5 <4> (ø) ⬇️
...seata/server/store/db/DbcpDataSourceGenerator.java 0% <0%> (-100%) 0% <0%> (-2%)
...eata/server/store/db/DruidDataSourceGenerator.java 0% <0%> (-100%) 0% <0%> (-2%)
...java/io/seata/spring/tcc/TccActionInterceptor.java 13.15% <0%> (-0.36%) 2% <0%> (ø)
...n/java/io/seata/rm/datasource/ConnectionProxy.java 26.05% <0%> (-0.23%) 12% <0%> (ø)
...a/io/seata/core/rpc/netty/AbstractRpcRemoting.java 10.55% <0%> (-0.22%) 4% <0%> (ø)
...ing/annotation/GlobalTransactionalInterceptor.java 9.85% <0%> (-0.15%) 2% <0%> (ø)
...in/java/io/seata/server/session/GlobalSession.java 84.44% <0%> (-0.11%) 73% <0%> (+1%)
...ata/core/store/db/AbstractDataSourceGenerator.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
...in/java/io/seata/server/session/BranchSession.java 78.1% <0%> (+0.07%) 44% <0%> (ø) ⬇️
... and 24 more

@zjinlei
Copy link
Contributor

zjinlei commented Mar 5, 2020

image
There are 4 in StoreConfig.java, it is recommended to change them to camel here.

@funky-eyes
Copy link
Contributor Author

image
There are 4 in StoreConfig.java, it is recommended to change them to camel here.

PTAL

Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjinlei zjinlei merged commit 826a725 into apache:develop Mar 7, 2020
@slievrly slievrly added this to the 1.2.0 milestone Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants