optimize: optimize the conditions for executing unlocking #3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caohdgege
reviewed
Oct 29, 2020
wangliang181230
changed the title
是的，你是对的，我已经将添加的判断条件移到clean方法中了。 |
Codecov Report
@@ Coverage Diff @@
## develop #3236 +/- ##
=============================================
- Coverage 51.57% 51.12% -0.46%
+ Complexity 3379 3303 -76
=============================================
Files 619 614 -5
Lines 20468 20133 -335
Branches 2563 2516 -47
=============================================
- Hits 10556 10292 -264
+ Misses 8852 8807 -45
+ Partials 1060 1034 -26 |
|
如果globalSession的status是Committing，AsyncCommitting，CommitRetrying的时候，那么GlobalSession#removeBranch的时候，其实也不需要unlock了，因为他在前面的closeAndClean的时候已经把lock都清除了，王良哥看一下要不要在这个pr里面一起处理一下。 |
…itting, CommitRetrying, AsyncCommitting)
… optimize-tcc-global-commit
wangliang181230
changed the title
wangliang181230
changed the title
wangliang181230
changed the title
funky-eyes
approved these changes
Jan 21, 2021
done |
…-tcc-global-commit
…-tcc-global-commit # Conflicts: # changes/1.5.0.md # changes/en-us/1.5.0.md
slievrly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
optimize: opt the conditions for executing unlocking.
优化：优化执行解锁的条件，避免不必要的unlock操作。
顺便修复了一个BUG：当TC的
server.rollbackRetryTimeoutUnlockEnable=true时，如果unlock出现异常，全局事务却删除成功时锁数据会遗留下来。当前PR优化了以下五种情况：
AT分支时，就不清理锁数据：包含4种情况。1.1. 全局提交刚开始，执行
closeAndClean()时，没有AT分支就不需要clean().1.2. 全局提交或全局回滚完成后，执行
SessionHelper.endXxxxed()方法时，因为已经没有分支数据了，不需要clean()。1.3. 当分支返回
PhaseTwo_CommitFailed_Unretryable或PhaseTwo_RollbackFailed_Unretryable时，当剩余分支没有AT分支时，不需要clean().1.4. SAGA事务，不需要
clean().unlock.Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews