Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Implementation of front-end page of globalsession query interface #4435

Merged
merged 42 commits into from
Mar 11, 2022
Merged

feature: Implementation of front-end page of globalsession query interface #4435

merged 42 commits into from
Mar 11, 2022

Conversation

liuqiufeng
Copy link
Contributor

@liuqiufeng liuqiufeng commented Mar 5, 2022 •
edited

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #4416
fixes #4417

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2022 •
edited

Codecov Report

Merging #4435 (33117cd) into develop (ea0607b) will increase coverage by 0.58%.
The diff coverage is 25.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #4435      +/-   ##
=============================================
+ Coverage      48.33%   48.91%   +0.58%     
- Complexity      3958     4001      +43     
=============================================
  Files            734      730       -4     
  Lines          25331    25245      -86     
  Branches        3115     3118       +3     
=============================================
+ Hits           12243    12349     +106     
+ Misses         11765    11568     -197     
- Partials        1323     1328       +5
Impacted Files Coverage Δ
...erver/console/controller/GlobalLockController.java 50.00% <ø> (ø)
...er/console/controller/GlobalSessionController.java 50.00% <ø> (ø)
...er/console/impl/db/BranchSessionDBServiceImpl.java 0.00% <ø> (ø)
...erver/console/impl/db/GlobalLockDBServiceImpl.java 0.00% <ø> (ø)
...er/console/impl/db/GlobalSessionDBServiceImpl.java 0.00% <0.00%> (ø)
...onsole/impl/file/BranchSessionFileServiceImpl.java 50.00% <ø> (ø)
...sole/impl/redis/BranchSessionRedisServiceImpl.java 0.00% <ø> (ø)
...console/impl/redis/GlobalLockRedisServiceImpl.java 0.00% <ø> (ø)
...sole/impl/redis/GlobalSessionRedisServiceImpl.java 0.00% <ø> (ø)
...io/seata/server/console/param/GlobalLockParam.java 65.00% <ø> (ø)
... and 22 more

@doubleDimple
Copy link
Contributor

标题少了开头，加一下

@liuqiufeng
Copy link
Contributor Author

标题少了开头，加一下

ok

@liuqiufeng liuqiufeng changed the title [WIP]Implementation of front-end page of globalsession query interface [WIP]feature: Implementation of front-end page of globalsession query interface Mar 5, 2022
funky-eyes
funky-eyes reviewed Mar 6, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
status这个按首字母排序一下吧
还有就是我选择了某一个status,怎么取消?
image
默认下不点搜索不会出现,建议默认还是请求一次接口读取下数据吧

@funky-eyes
Copy link
Contributor

image
假设我在92页点击了下搜索,此时事务已经全部处理完了,然后我再点击一次搜索的时候,页数还是92,当没有数据满足的时候应该重置页数为第一页

@funky-eyes funky-eyes added this to the 1.5.0 milestone Mar 6, 2022
@funky-eyes funky-eyes added module/console module/server server module type: feature Category issues or prs related to feature request. labels Mar 6, 2022
@funky-eyes
Copy link
Contributor

想到个事，默认设置为中文吧，每次进去是英文的怪难受的

@liuqiufeng liuqiufeng changed the title [WIP]feature: Implementation of front-end page of globalsession query interface feature: Implementation of front-end page of globalsession query interface Mar 7, 2022
funky-eyes
funky-eyes approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

objcoding
objcoding approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@objcoding objcoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@funky-eyes funky-eyes merged commit dec8dcb into apache:develop Mar 11, 2022
@liuqiufeng liuqiufeng deleted the page_of_global_session branch March 23, 2022 02:22
Bughue pushed a commit to Bughue/seata that referenced this pull request Mar 25, 2022
@liuqiufeng @Bughue
feature: Implementation of front-end page of globalsession query inte…
fc9f76d 
…rface (apache#4435)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@funky-eyes funky-eyes funky-eyes approved these changes

@objcoding objcoding objcoding approved these changes

Assignees
No one assigned
Labels
module/console module/server server module type: feature Category issues or prs related to feature request.
Projects
None yet
Milestone
1.5.0 (1.5.1)
6 participants
@liuqiufeng @codecov-commenter @doubleDimple @funky-eyes @objcoding @lvekee